Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: normalize quoting with black #1916

Merged

Conversation

aucampia
Copy link
Member

Summary of changes

This patch will result in black normalizing string quoting. This makes
for a more consistent codebase, this will mostly affect tests as this
setting was effectively enabled for some time on rdflib/.

Checklist

  • Checked that there aren't other open pull requests for
    the same change.
  • Checked that all tests and type checking passes.
  • Considered granting push permissions to the PR branch,
    so maintainers can fix minor issues and keep your PR up to date.

@aucampia aucampia changed the title style: ca quoting with black style: normalize quoting with black May 12, 2022
@aucampia
Copy link
Member Author

pre-commit.ci autofix

@aucampia aucampia requested a review from a team May 12, 2022 19:59
@aucampia
Copy link
Member Author

Not sure why this was disabled but I think it makes things a bit easier if string quoting is normalized.

@coveralls
Copy link

coveralls commented May 12, 2022

Coverage Status

Coverage remained the same at 88.432% when pulling 93e2661 on aucampia:iwana-20220512T2152-consistent_quoting into 32923ce on RDFLib:master.

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Definitely worth it.

@aucampia aucampia requested a review from a team May 14, 2022 18:37
@aucampia aucampia added the review wanted This indicates that the PR is ready for review label May 14, 2022
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

confirmed

@aucampia aucampia force-pushed the iwana-20220512T2152-consistent_quoting branch 2 times, most recently from c9ab854 to 9dbffa9 Compare May 16, 2022 19:59
This patch will result in black normalizing string quoting. This makes
for a more consistent codebase, this will mostly affect tests as this
setting was effectively enabled for some time on `rdflib/`.
@aucampia aucampia force-pushed the iwana-20220512T2152-consistent_quoting branch from 9dbffa9 to 9ad7c73 Compare May 19, 2022 17:30
@aucampia
Copy link
Member Author

pre-commit.ci autofix

@aucampia
Copy link
Member Author

Merging this with only one approval as the only thing that made changes to runtime code here is black (via pre-commit.ci).

@aucampia aucampia merged commit ba855c2 into RDFLib:master May 19, 2022
@ghost ghost removed the review wanted This indicates that the PR is ready for review label Jun 4, 2022
@aucampia aucampia deleted the iwana-20220512T2152-consistent_quoting branch June 4, 2022 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants