Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to latest DAWG test suite #1925

Merged
merged 2 commits into from May 13, 2022

Conversation

aucampia
Copy link
Member

Summary of changes

This patch changes test/test_w3c_spec/test_sparql_w3c.py to use the final
DAWG data-r2 test suite instead of an older version.

Split off from #1891

Checklist

  • Checked that there aren't other open pull requests for
    the same change.
  • Checked that all tests and type checking passes.
  • Considered granting push permissions to the PR branch,
    so maintainers can fix minor issues and keep your PR up to date.

Graham Higgins and others added 2 commits May 13, 2022 20:30
This patch changes `test/test_w3c_spec/test_sparql_w3c.py` to use the final
DAWG data-r2 test suite instead of an older version.
- Remove `DAWG.Proposed`.

  This is not defined in the DAWG vocab or used in any tests as far
  as I can tell.

- Rename `test/skipped_sparql_tests.py` to
  `test/test_w3c_spec/test_sparql_w3c_skipped.py`.

  This is so it is closer to the file that uses it.

- removed `skiptests.list` and `test/skiptests.list`

  These are now replaced by `test/test_w3c_spec/test_sparql_w3c_skipped.py`

- Remove test that pass from skipped tests.
@aucampia
Copy link
Member Author

aucampia commented May 13, 2022

@gjhiggins I made some changes to what you did:

9be390e

  • Remove DAWG.Proposed.

    This is not defined in the DAWG vocab or used in any tests as far
    as I can tell.

  • Rename test/skipped_sparql_tests.py to
    test/test_w3c_spec/test_sparql_w3c_skipped.py.

    This is so it is closer to the file that uses it.

  • removed skiptests.list and test/skiptests.list

    These are now replaced by test/test_w3c_spec/test_sparql_w3c_skipped.py

  • Remove test that pass from skipped tests.

@coveralls
Copy link

coveralls commented May 13, 2022

Coverage Status

Coverage remained the same at 88.248% when pulling 9be390e on aucampia:iwana-20220513T2002-new_dawg_suite into e5f3f1f on RDFLib:master.

@aucampia aucampia force-pushed the iwana-20220513T2002-new_dawg_suite branch from 017708f to 9be390e Compare May 13, 2022 19:12
@aucampia aucampia marked this pull request as ready for review May 13, 2022 19:12
@aucampia aucampia requested review from a user May 13, 2022 19:12
@aucampia
Copy link
Member Author

  • Remove DAWG.Proposed.
    This is not defined in the DAWG vocab or used in any tests as far
    as I can tell.

Ref https://www.w3.org/2001/sw/DataAccess/tests/test-dawg#

Also:

$ grep -r Proposed test/data/suites/w3c/dawg-data-r2/
$ 

@aucampia aucampia mentioned this pull request May 13, 2022
4 tasks
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

aha, didn't actually investigate DAWG Proposed, tsk.

All good.

@aucampia aucampia merged commit 3fa13c3 into RDFLib:master May 13, 2022
@aucampia aucampia deleted the iwana-20220513T2002-new_dawg_suite branch June 4, 2022 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants