feat: add typing for rdflib/plugins/sparql
#1926
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
approved these changes
May 13, 2022
aucampia
changed the title
rdflib/plugins/sparqlrdflib/plugins/sparql
This patch adds typing to two files and changes imports so that they are more specific to the module in which classes are defined. This patch contains no runtime changes. I'm adding this to make it easier to spot bugs in new PRs to SPARQL code.
aucampia
force-pushed
the
iwana-20220513T2207-typing_sparql
branch
from
a1959ca
to
165b3c0
Compare
Changing these names now will break our interface, so best to just accept the broken naming there.
ghost
removed
the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Only adds typing to two files, will add more later.
I'm adding this to make it easier to spot bugs in new PRs to SPARQL
code.
Checklist
the same change.
so maintainers can fix minor issues and keep your PR up to date.