Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added SPARQL unicode numeric codepoint escape tests #1929

Merged
merged 1 commit into from May 14, 2022
Merged

Added SPARQL unicode numeric codepoint escape tests #1929

merged 1 commit into from May 14, 2022

Conversation

aucampia
Copy link
Member

@aucampia aucampia commented May 14, 2022 •
edited

Summary of changes

Added four (marked-as-xfail) unicode numeric codepoint escape tests
to the RDFLib-specific SPARQL test suite test/data/suites/rdflib/sparql.

Also:

  • Fix the base URI in the RDFLib SPARQL test manifest.

Split off from #1891

Checklist

  • Checked that there aren't other open pull requests for
    the same change.
  • Checked that all tests and type checking passes.
  • Considered granting push permissions to the PR branch,
    so maintainers can fix minor issues and keep your PR up to date.

@aucampia
Added SPARQL unicode numeric codepoint escape tests
03e8cac 
Added four (marked-as-xfail) unicode numeric codepoint escape tests
to the RDFLib-specific SPARQL test suite `test/data/suites/rdflib/sparql`.

Also:
- Fix the base URI in the RDFLib SPARQL test manifest.
@aucampia aucampia marked this pull request as ready for review May 14, 2022 17:49
@aucampia aucampia mentioned this pull request May 14, 2022
Merged
4 tasks
@coveralls
Copy link

Coverage Status

Coverage remained the same at 88.248% when pulling 03e8cac on aucampia:iwana-20220514T1938-extra_sparql_tests into 7d496bc on RDFLib:master.

@aucampia aucampia added the review wanted This indicates that the PR is ready for review label May 14, 2022
@ghost ghost self-requested a review May 14, 2022 20:59
ghost
ghost approved these changes May 14, 2022
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@aucampia aucampia merged commit c30cc3c into RDFLib:master May 14, 2022
@ghost ghost removed the review wanted This indicates that the PR is ready for review label Jun 4, 2022
@aucampia aucampia deleted the iwana-20220514T1938-extra_sparql_tests branch June 4, 2022 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@aucampia @coveralls