feat: add tests and typing for rdflib.utils.{get_tree,find_roots}
#1935
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aucampia
force-pushed
the
iwana-20220514T2354-test_utils
branch
from
9f1ca7b
to
8c94f8d
Compare
aucampia
changed the title
rdflib.utils.{get_tree,find_roots}rdflib.utils.{get_tree,find_roots}
I wanted to see if these are useful for what I wanted to do and I was unsure about what exactly they are doing, wanted to be sure so I added some tests to check the current behavior. Also: - Add rdftest.ttl to `test/data/defined_namespaces/` using fetcher I'm using it to test `get_tree` and `find_roots`.
aucampia
force-pushed
the
iwana-20220514T2354-test_utils
branch
from
8c94f8d
to
1f6e2c7
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
ghost
removed
the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
I wanted to see if these are useful for what I wanted to do and I was
unsure about what exactly they are doing, wanted to be sure so I added
some tests to check the current behavior.
Checklist
the same change.
so maintainers can fix minor issues and keep your PR up to date.