Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix outmoded x and x or y idiom in infixowl.py #1943

Merged
merged 7 commits into from May 25, 2022
Merged

fix outmoded x and x or y idiom in infixowl.py #1943

merged 7 commits into from May 25, 2022

Conversation

ghost
Copy link

@ghost ghost commented May 15, 2022

Summary of changes

Change x and x or y idiom for modern, clearer y if x is None else x, as suggested by sonarcloud analysis

Checklist

  • Checked that there aren't other open pull requests for the same change.
  • Checked that all tests and type checking passes.
  • Considered granting push permissions to the PR branch,
    so maintainers can fix minor issues and keep your PR up to date.

@ghost ghost self-requested a review May 15, 2022 15:34
@sonarcloud
Copy link

sonarcloud bot commented May 15, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@coveralls
Copy link

coveralls commented May 15, 2022

Coverage Status

Coverage remained the same at 88.437% when pulling a22ad4e on gjhiggins:fix-infixowl-old-idiom-use into a3a4611 on RDFLib:master.

Copy link
Member

@aucampia aucampia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT

@aucampia aucampia requested a review from a team May 15, 2022 16:38
@aucampia aucampia added the review wanted This indicates that the PR is ready for review label May 17, 2022
@aucampia
Copy link
Member

Will merge by 2022-05-25 if there is no further feedback.

@aucampia aucampia merged commit eff3b31 into RDFLib:master May 25, 2022
@ghost ghost deleted the fix-infixowl-old-idiom-use branch May 26, 2022 10:03
@ghost ghost removed the review wanted This indicates that the PR is ready for review label Jun 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants