Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: remove unused imports in test code #1947

Merged
merged 2 commits into from May 16, 2022
Merged

test: remove unused imports in test code #1947

merged 2 commits into from May 16, 2022

Conversation

aucampia
Copy link
Member

Summary of changes

This patch removes unused imports in test code. This is mainly to remove
the potential snag for flake8/flakeheaven.

The actual cleanup was done with pycln --all test.

Also:

  • Remove superflous pass statements.

Checklist

  • Checked that there aren't other open pull requests for
    the same change.
  • Checked that all tests and type checking passes.
  • Considered granting push permissions to the PR branch,
    so maintainers can fix minor issues and keep your PR up to date.

@aucampia
test: remove unused imports in test code
fc3a94a 
This patch removes unused imports in test code. This is mainly to remove
the potential snag for flake8/flakeheaven.

The actual cleanup was done with `pycln --all test`.

Also:
 - Remove superflous `pass` statements.
@sonarcloud
Copy link

sonarcloud bot commented May 16, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@aucampia aucampia marked this pull request as ready for review May 16, 2022 18:53
@coveralls
Copy link

coveralls commented May 16, 2022 •
edited

Coverage Status

Coverage remained the same at 88.423% when pulling 2859304 on aucampia:iwana-20220516T2046-test_clean_import into a2866cd on RDFLib:master.

@aucampia
Copy link
Member Author

pre-commit.ci autofix

@aucampia aucampia requested a review from a team May 16, 2022 19:23
ghost
ghost approved these changes May 16, 2022
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hm pycln, must remember that one

@aucampia aucampia merged commit 3c72ce1 into RDFLib:master May 16, 2022
@aucampia aucampia deleted the iwana-20220516T2046-test_clean_import branch June 4, 2022 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@aucampia @coveralls