Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: ignore flake8 name errors for existing names #1948

Merged

Conversation

aucampia
Copy link
Member

Summary of changes

This patch setups up some flake8 ignores for names that will come up
more in the future now that we have flakehell running.

One case where this is relevant:

Checklist

  • Checked that there aren't other open pull requests for
    the same change.
  • Checked that all tests and type checking passes.
  • Considered granting push permissions to the PR branch,
    so maintainers can fix minor issues and keep your PR up to date.

This patch setups up some flake8 ignores for names that will come up
more in the future now that we have flakehell running.

One case where this is relevant:
- RDFLib#1944
@coveralls
Copy link

Coverage Status

Coverage remained the same at 88.423% when pulling 6ccd15e on aucampia:iwana-20220516T2115-ignore_existing_names into a2866cd on RDFLib:master.

@aucampia aucampia marked this pull request as ready for review May 16, 2022 19:52
@aucampia aucampia requested a review from a team May 16, 2022 19:52
@aucampia aucampia merged commit 35bdde3 into RDFLib:master May 16, 2022
@aucampia aucampia deleted the iwana-20220516T2115-ignore_existing_names branch June 4, 2022 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants