test: convert test/jsonld/test_util.py to pytest
#1961
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not the most straight forward conversion, but it simplifies it somewhat. Main reason for doing this is to remove the use of unittest.subTest as we need `pytest-subtest` to process that with pytest and that dependency is causing some complications in dependency solving for pip sometimes.
aucampia
force-pushed
the
iwana-20220521T1529-pytest_jsonld_utils
branch
from
c692bfd
to
bfb21c3
Compare
aucampia
changed the title
test/jsonld/test_util.py to pytesttest/jsonld/test_util.py to pytest
ghost
removed
the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Not the most straight forward conversion, but it simplifies it somewhat.
Main reason for doing this is to remove the use of unittest.subTest as
we need
pytest-subtestto process that with pytest and that dependencyis causing some complications in dependency solving for pip sometimes.
Cleaner diff can be obtained by hiding whitespaces: https://github.com/RDFLib/rdflib/pull/1961/files?diff=split&w=1
Checklist
the same change.
so maintainers can fix minor issues and keep your PR up to date.