Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more typing for SPARQL #1965

Merged

Conversation

aucampia
Copy link
Member

Summary of changes

This adds typing to rdflib/plugins/sparql/algebra.py
and rdflib/plugins/sparql/parserutils.py.

This is mainly being done to help detect issues in the new PRs that were
recently opened that relate to SPARQL.

This patch contain no runtime changes.

Checklist

  • Checked that there aren't other open pull requests for
    the same change.
  • Checked that all tests and type checking passes.
  • Considered granting push permissions to the PR branch,
    so maintainers can fix minor issues and keep your PR up to date.

This adds typing to `rdflib/plugins/sparql/algebra.py`
and `rdflib/plugins/sparql/parserutils.py`.

This is mainly being done to help detect issues in the new PRs that were
recently opened that relate to SPARQL.

This patch contain no runtime changes.
@aucampia aucampia marked this pull request as ready for review May 21, 2022 16:24
@aucampia aucampia requested a review from a team May 21, 2022 16:26
@aucampia aucampia added the review wanted This indicates that the PR is ready for review label May 21, 2022
@coveralls
Copy link

coveralls commented May 21, 2022

Coverage Status

Coverage decreased (-0.0004%) to 88.513% when pulling 3cdb550 on aucampia:iwana-20220521T1742-more_sparql_typing into 958b9a1 on RDFLib:master.

@aucampia aucampia merged commit 9ce7724 into RDFLib:master May 26, 2022
@ghost ghost removed the review wanted This indicates that the PR is ready for review label Jun 4, 2022
@aucampia aucampia deleted the iwana-20220521T1742-more_sparql_typing branch June 4, 2022 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants