Remove pytest-subtest
#1973
Merged
Remove pytest-subtest
#1973
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`unittest.TestCase.subTest` is a `unittest` construct that should be avoided in favor of pytest parameterization. `pytest-subtest` is a pytest plugin that adds support for `unittest.TestCase.subTest` to pytest. This plugin was needed in the past due to the use of `subTest`, but all uses of `subTest` has been replaced with pytest parameterization recently. The removal of this plugin is desirable as it bumps heads with other plugins that are useful and generally `subTest` should be avoided due to limitations in annotating this with skip of xfail.
ghost
approved these changes
Jun 5, 2022
ghost
removed
the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
unittest.TestCase.subTestis aunittestconstruct that should beavoided in favor of pytest parameterization.
pytest-subtestis a pytest plugin that adds support forunittest.TestCase.subTestto pytest.This plugin was needed in the past due to the use of
subTest, but all uses ofsubTesthas been replaced with pytest parameterization recently.The removal of this plugin is desirable as it bumps heads with other
plugins that are useful and generally
subTestshould be avoided due tolimitations in annotating this with skip of xfail.
Checklist
the same change.
so maintainers can fix minor issues and keep your PR up to date.