Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more namespaces to test utils #1980

Merged

Conversation

aucampia
Copy link
Member

@aucampia aucampia commented Jun 4, 2022

Summary of changes

This patch adds the following namespaces to test.utils.namespace as
DefinedNamespaces:

  • DAWGT: http://www.w3.org/2001/sw/DataAccess/tests/test-dawg#
  • MF: http://www.w3.org/2001/sw/DataAccess/tests/test-manifest#
  • QT: http://www.w3.org/2001/sw/DataAccess/tests/test-query#
  • UT: http://www.w3.org/2009/sparql/tests/test-update#

Other changes:

  • Change test_sparql_w3c.py to use the new defined namespaces.
  • Change logging format for pytest to include milliseconds so it is
    easier to see what is slow.
  • Ignore -N815 for test/utils/namespace/_*
  • Add source files for manifests to test/data/defined_namespaces, this
    is so we can use them in tests.

Checklist

  • Checked that there aren't other open pull requests for
    the same change.
  • Checked that all tests and type checking passes.
  • Considered granting push permissions to the PR branch,
    so maintainers can fix minor issues and keep your PR up to date.

This patch adds the following namespaces to `test.utils.namespace` as
`DefinedNamespace`s:

- DAWGT: `http://www.w3.org/2001/sw/DataAccess/tests/test-dawg#`
- MF: `http://www.w3.org/2001/sw/DataAccess/tests/test-manifest#`
- QT: `http://www.w3.org/2001/sw/DataAccess/tests/test-query#`
- UT: `http://www.w3.org/2009/sparql/tests/test-update#`

Other changes:

- Change `test_sparql_w3c.py` to use the new defined namespaces.
- Change logging format for pytest to include milliseconds so it is
  easier to see what is slow.
- Ignore `-N815` for `test/utils/namespace/_*`
- Add source files for manifests to `test/data/defined_namespaces`, this
  is so we can use them in tests.
@aucampia aucampia marked this pull request as ready for review June 4, 2022 18:52
@aucampia aucampia requested a review from a team June 4, 2022 18:52
@aucampia aucampia added the review wanted This indicates that the PR is ready for review label Jun 4, 2022
@coveralls
Copy link

Coverage Status

Coverage remained the same at 88.521% when pulling 50e05e7 on aucampia:iwana-20220604T2034-test_namespaces into aa33f9a on RDFLib:master.

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes!!

@aucampia aucampia merged commit 3447dc1 into RDFLib:master Jun 5, 2022
@ghost ghost removed the review wanted This indicates that the PR is ready for review label Jun 8, 2022
@aucampia aucampia deleted the iwana-20220604T2034-test_namespaces branch June 23, 2022 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants