Add more tests for graph_diff #1983
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aucampia
force-pushed
the
iwana-20220604T2208-quad_diff
branch
2 times, most recently
from
9d26fa2
to
1394f60
Compare
This is to confirm that `graph_diff` does not work with quads. Other changes: - Added support to GraphHelper for collapsing BNodes to a specifc IRI when coverting to triple sets, this is in addition to the current functionality for ignoring bnodes. This makes it possible to more accurately compare Graphs that contain blank nodes. - Added `assert_cgraph_isomorphic` to GraphHelper. This method adds some rudementary support for checking if conjunctive graphs are isomorphic, it will ignore name graphs that have blank nodes as name.
aucampia
force-pushed
the
iwana-20220604T2208-quad_diff
branch
from
1394f60
to
a51580f
Compare
ghost
removed
the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
This is to confirm that
graph_diffdoes not work with quads.Other changes:
when coverting to triple sets, this is in addition to the current
functionality for ignoring bnodes. This makes it possible to more
accurately compare Graphs that contain blank nodes.
assert_cgraph_isomorphicto GraphHelper.This method adds some rudementary support for checking if conjunctive
graphs are isomorphic, it will ignore named graphs that have blank
nodes as name.
Checklist
the same change.
so maintainers can fix minor issues and keep your PR up to date.