Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Continuation of infixowl update and coverage improvement #2001

Merged
merged 6 commits into from Jul 13, 2022
Merged

Continuation of infixowl update and coverage improvement #2001

merged 6 commits into from Jul 13, 2022

Conversation

ghost
Copy link

@ghost ghost commented Jun 24, 2022

Summary of changes

Update of infixowl including a couple of minor run-time changes to avoid exceptions currently xfailing.

i) Continued improvement of coverage.
ii) Addressing of non-API flake8 issues of function and variable naming.

(Either as separate PRs or separate commits)

iii) Removal of non-functioning/unused code
iv) Change processing order in some methods to avoid raising Exceptions when arg is None
v) Further development of tests of infixowl functioning.
vi) Minor streamlining.
vii) Add documentation to illuminate noun and name ACE annotation usage

Checklist

  • Checked that there aren't other open pull requests for the same change.
  • Added tests for any changes that have a runtime impact.
  • Checked that all tests and type checking passes.
  • For changes that have a potential impact on users of this project:
    • Updated relevant documentation to avoid inaccuracies.
    • Considered adding additional documentation.
    • Considered adding an example in ./examples for new features.
    • Considered updating our changelog (CHANGELOG.md).
  • Considered granting push permissions to the PR branch,
    so maintainers can fix minor issues and keep your PR up to date.

@coveralls
Copy link

coveralls commented Jun 24, 2022

Coverage Status

Coverage increased (+0.1%) to 90.361% when pulling 559d7f5 on gjhiggins:infixowl-coverage-ii into 4f96f46 on RDFLib:master.

@ghost ghost self-requested a review June 24, 2022 16:17
Copy link
Member

@aucampia aucampia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks good to me, will merge later today if there is no further feedback.

@aucampia aucampia merged commit ac8ef91 into RDFLib:master Jul 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants