Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: removed "Other changes" from CHANGELOG.md #2031

Merged
merged 1 commit into from Jul 18, 2022

Conversation

aucampia
Copy link
Member

@aucampia aucampia commented Jul 17, 2022

Summary of changes

Removed the "Other changes" section as there is really no good reason
to include details about changes that don't impact users.

Other changes:

  • Added instructions for updating the CHANGELOG in a comment.
  • Fixed the commands for generating a list of merged PRs.

Checklist

  • Checked that there aren't other open pull requests for
    the same change.
  • Checked that all tests and type checking passes.
  • Considered granting push permissions to the PR branch,
    so maintainers can fix minor issues and keep your PR up to date.

@aucampia aucampia changed the title docs: updated CHANGELOG.md docs: removed "Other changes" from CHANGELOG.md Jul 17, 2022
@aucampia aucampia requested a review from a team July 17, 2022 15:57
@coveralls
Copy link

coveralls commented Jul 17, 2022

Coverage Status

Coverage remained the same at 90.445% when pulling f6f186c on iwana-20220717T1746-changelog into 8d5a14f on master.

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

- Removed the "Other changes" section as there is really no good reason
  to include details about changes that don't impact users.
- Added instructions for updating the CHANGELOG in a comment.
- Fixed the commands for generating a list of merged PRs.
@aucampia aucampia force-pushed the iwana-20220717T1746-changelog branch from 17fb93a to f6f186c Compare July 18, 2022 12:35
@aucampia aucampia merged commit 63ff76c into master Jul 18, 2022
@aucampia aucampia deleted the iwana-20220717T1746-changelog branch July 18, 2022 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants