build: Taskfile improvements #2032
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aucampia
force-pushed
the
iwana-20220717T1633-taskfile
branch
4 times, most recently
from
4d4e32c
to
c45070e
Compare
aucampia
force-pushed
the
iwana-20220717T1633-taskfile
branch
from
c45070e
to
bc285a3
Compare
|
I'm going to update this to also change how pytest is invoked to address this comment: #1519 (comment) |
aucampia
force-pushed
the
iwana-20220717T1633-taskfile
branch
from
bc285a3
to
33b1fb1
Compare
aucampia
force-pushed
the
iwana-20220717T1633-taskfile
branch
from
33b1fb1
to
4ff6b11
Compare
- Added individual tasks for black, isort and mypy to make it easier to run these directly. - Change flag variables to be JSON based so that they can be disabled with "false", this makes it easier to work with tooling that does not distinguish between empty and unset environment variables. - Add a `venv:run` target to make it easier to run things inside the venv, e.g. `task venv:run -- pip install lxml`. - Change pytest invocation to use the pytest script instead of using `python -m pytest` as the latter does some things which are not desirable.
aucampia
force-pushed
the
iwana-20220717T1633-taskfile
branch
from
4ff6b11
to
6553986
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
run these directly.
with "false", this makes it easier to work with tooling that does not
distinguish between empty and unset environment variables.
venv:runtarget to make it easier to run things inside thevenv, e.g.
task venv:run -- pip install lxml.python -m pytestas the latter does some things which are notdesirable.
Checklist
the same change.
so maintainers can fix minor issues and keep your PR up to date.