Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Toplevel n80x #2046

Merged
merged 14 commits into from Jul 28, 2022
Merged

Toplevel n80x #2046

merged 14 commits into from Jul 28, 2022

Conversation

ghost
Copy link

@ghost ghost commented Jul 21, 2022

Handful of fixes for PEP8 naming convention violations.

Summary of changes

Changes to argument names not impacting the API, noqa pragmas added for convention violations that appear in the published API. Added deprecation to paths.evalPath()

Checklist

  • Checked that there aren't other open pull requests for the same change.
  • Checked that all tests and type checking passes.
  • Considered granting push permissions to the PR branch,
    so maintainers can fix minor issues and keep your PR up to date.

@coveralls
Copy link

coveralls commented Jul 21, 2022

Coverage Status

Coverage decreased (-0.008%) to 90.477% when pulling f8942e5 on gjhiggins:toplevel-n80x into 0856ac8 on RDFLib:master.

rdflib/compat.py Outdated Show resolved Hide resolved
rdflib/paths.py Outdated Show resolved Hide resolved
rdflib/query.py Outdated Show resolved Hide resolved
rdflib/compat.py Outdated Show resolved Hide resolved
rdflib/query.py Outdated Show resolved Hide resolved
Copy link
Member

@aucampia aucampia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aucampia
Copy link
Member

Will merge tomorrow

@aucampia aucampia merged commit 3e2987b into RDFLib:master Jul 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants