Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: fix Taskfile.yml for Windows #2064

Merged

Conversation

aucampia
Copy link
Member

Summary of changes

Fix some issues that the Taskfile had on Windows, mostly related to
shell quoting. Mainly doing this because I'm trying to fix some Windows
specific issues and tasks in the Taskfile make it easier to work on
Windows provided they work correctly.

Other changes:

  • Add a separate task for creating a venv.

Checklist

  • Checked that there aren't other open pull requests for
    the same change.
  • Checked that all tests and type checking passes.
  • Considered granting push permissions to the PR branch,
    so maintainers can fix minor issues and keep your PR up to date.

Fix some issues that the Taskfile had on Windows, mostly related to
shell quoting. Mainly doing this because I'm trying to fix some Windows
specific issues and tasks in the Taskfile make it easier to work on
Windows provided they work correctly.

Other changes:
- Add a separate task for creating a venv.
@aucampia aucampia added meta Relates primarily to the project and not users of the project. review wanted This indicates that the PR is ready for review labels Jul 29, 2022
@coveralls
Copy link

Coverage Status

Coverage remained the same at 90.486% when pulling b929e11 on aucampia:iwana-20220729T1841-taskfile_windows into 3e2987b on RDFLib:master.

@aucampia aucampia requested a review from a team July 29, 2022 17:46
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@aucampia aucampia merged commit 346ccba into RDFLib:master Jul 29, 2022
@aucampia aucampia deleted the iwana-20220729T1841-taskfile_windows branch April 9, 2023 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
meta Relates primarily to the project and not users of the project. review wanted This indicates that the PR is ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants