Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: set a minimum version for flakeheaven #2068

Merged
merged 1 commit into from Jul 31, 2022
Merged

build: set a minimum version for flakeheaven #2068

merged 1 commit into from Jul 31, 2022

Conversation

aucampia
Copy link
Member

Summary of changes

Without this a very old flakeheaven is selected which does not work.
This is likely due to the new release of flakeheaven having some version
constraints that bump heads with other dependencies.

Without this the flake8 step of CI fails consistently.

Checklist

  • Checked that there aren't other open pull requests for
    the same change.
  • Checked that all tests and type checking passes.
  • Considered granting push permissions to the PR branch,
    so maintainers can fix minor issues and keep your PR up to date.

@aucampia
build: set a minimum version for flakeheaven
696d4f6 
Without this a very old flakeheaven is selected which does not work.
This is likely due to the new release of flakeheaven having some version
constraints that bump heads with other dependencies.

Without this the flake8 step of CI fails consistently.
@coveralls
Copy link

Coverage Status

Coverage remained the same at 90.456% when pulling 696d4f6 on aucampia:iwana-20220731T0137-pin_flakeheaven into 283bef2 on RDFLib:master.

@aucampia aucampia marked this pull request as ready for review July 31, 2022 00:07
@aucampia aucampia requested a review from a team July 31, 2022 00:07
@aucampia aucampia added the meta Relates primarily to the project and not users of the project. label Jul 31, 2022
@aucampia aucampia mentioned this pull request Jul 31, 2022
Merged
5 tasks
ghost
ghost approved these changes Jul 31, 2022
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@aucampia aucampia merged commit 8d58fd0 into RDFLib:master Jul 31, 2022
@aucampia aucampia deleted the iwana-20220731T0137-pin_flakeheaven branch April 9, 2023 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
Assignees
No one assigned
Labels
meta Relates primarily to the project and not users of the project.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@aucampia @coveralls