Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: honour lax cardinality from test manifests #2074

Merged

Conversation

aucampia
Copy link
Member

@aucampia aucampia commented Aug 4, 2022

Summary of changes

Honour lax cardinality by only considering the first time a specific
binding occurred in a result when testing result equality.

This was causing a test to fail that required lax cardinality when
comparing.

Checklist

  • Checked that there aren't other open pull requests for
    the same change.
  • Checked that all tests and type checking passes.
  • Considered granting push permissions to the PR branch,
    so maintainers can fix minor issues and keep your PR up to date.

Honour lax cardinality by only considering the first time a specific
binding occured in a result when testing result equality.

This was causing a test to fail that required lax cardinality when
comparing.
@aucampia aucampia force-pushed the iwana-20220804T2321-honor_lax_cardinality branch from 98e151c to dc97909 Compare August 4, 2022 21:27
@aucampia aucampia marked this pull request as ready for review August 4, 2022 21:30
@aucampia aucampia requested a review from a team August 4, 2022 21:30
@coveralls
Copy link

coveralls commented Aug 4, 2022

Coverage Status

Coverage remained the same at 90.447% when pulling dc97909 on aucampia:iwana-20220804T2321-honor_lax_cardinality into cc80c9c on RDFLib:master.

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice one!

@aucampia aucampia merged commit 9f64823 into RDFLib:master Aug 7, 2022
@aucampia aucampia deleted the iwana-20220804T2321-honor_lax_cardinality branch April 9, 2023 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants