Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: content-type handling with SPARQLStore + CONSTRUCT queries #2092

Merged
merged 1 commit into from Aug 23, 2022
Merged

test: content-type handling with SPARQLStore + CONSTRUCT queries #2092

merged 1 commit into from Aug 23, 2022

Conversation

aucampia
Copy link
Member

Summary of changes

Confirm various content type values are handled correctly with CONSTRUCT
queries and SPARQLStore.

This aims to confirm that #1195 is fixed.

Checklist

  • Checked that there aren't other open pull requests for
    the same change.
  • Checked that all tests and type checking passes.
  • Considered granting push permissions to the PR branch,
    so maintainers can fix minor issues and keep your PR up to date.

@aucampia
test: content-type handling with SPARQLStore + CONSTRUCT queries
2ce330b 
Confirm various content type values are handled correctly with CONSTRUCT
queries and SPARQLStore.

This aims to confirm that RDFLib#1195 is fixed.
@coveralls
Copy link

Coverage Status

Coverage increased (+0.02%) to 90.481% when pulling 2ce330b on aucampia:iwana-20220821T1450-sparqlstore_formats into a39d143 on RDFLib:master.

@aucampia aucampia marked this pull request as ready for review August 21, 2022 14:38
@aucampia aucampia requested a review from a team August 21, 2022 14:38
@aucampia aucampia added the review wanted This indicates that the PR is ready for review label Aug 21, 2022
ghost
ghost approved these changes Aug 23, 2022
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@aucampia aucampia merged commit 2ce4e2b into RDFLib:master Aug 23, 2022
@aucampia aucampia mentioned this pull request Aug 23, 2022
Closed
@aucampia aucampia deleted the iwana-20220821T1450-sparqlstore_formats branch April 9, 2023 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
Assignees
No one assigned
Labels
review wanted This indicates that the PR is ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@aucampia @coveralls