New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Don't register berkelydb as a store if it is not available on the system #2096
Conversation
Added check in plugin.py for berkeleyDB availability (find actual changelog format so I don't look like a dumbass)
Added check in plugin.py for berkeleyDB availability (find actual changelog format so I don't look like a dumbass)
Added check in plugin.py for berkeleyDB availability
Removed import rdflib.plugins.stores.berkeleydb.has_bsddb in test_graph.py Added if statement in plugin.py for berkeleyDB availability
Whoops! Sorry about the unprofessional language and weird descriptions in the commit list! I'm still learning how github works and thought it would update differently. |
No worries :) thanks for the PR, from a quick glance it looks good, will check a bit closer once CI has completed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change looks good to me, but maybe the comment at the end of rdflib/plugin.py
is not needed.
Thanks again for the PR, I will include some note in the CHANGELOG.md
and merge sometime in the next couple of days, probably before friday.
Also remove a stray comment.
I added a CHANGELOG entry to your branch, feel free to change it if you want, I will check it again before I merge it. |
Summary of changes
Fixes #1816
import rdflib.plugins.stores.berkeleydb.has_bsddb
Checklist
the same change.
so maintainers can fix minor issues and keep your PR up to date.