Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Don't register berkelydb as a store if it is not available on the system #2096

Merged
merged 5 commits into from Aug 23, 2022

Conversation

eden-logistics
Copy link
Contributor

Summary of changes

Fixes #1816

  • Added berkeleydb check in plugin.py
  • Removed exception in test_graph.py
  • Removed import rdflib.plugins.stores.berkeleydb.has_bsddb

Checklist

  • Checked that there aren't other open pull requests for
    the same change.
  • Checked that all tests and type checking passes.
  • Considered granting push permissions to the PR branch,
    so maintainers can fix minor issues and keep your PR up to date.

Added check in plugin.py for berkeleyDB availability
(find actual changelog format so I don't look like a dumbass)
Added check in plugin.py for berkeleyDB availability
(find actual changelog format so I don't look like a dumbass)
Added check in plugin.py for berkeleyDB availability
Removed import rdflib.plugins.stores.berkeleydb.has_bsddb in test_graph.py
Added if statement in plugin.py for berkeleyDB availability
@eden-logistics
Copy link
Contributor Author

Whoops! Sorry about the unprofessional language and weird descriptions in the commit list! I'm still learning how github works and thought it would update differently.

@aucampia
Copy link
Member

Whoops! Sorry about the unprofessional language and weird descriptions in the commit list! I'm still learning how github works and thought it would update differently.

No worries :) thanks for the PR, from a quick glance it looks good, will check a bit closer once CI has completed

rdflib/plugin.py Outdated Show resolved Hide resolved
Copy link
Member

@aucampia aucampia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks good to me, but maybe the comment at the end of rdflib/plugin.py is not needed.

Thanks again for the PR, I will include some note in the CHANGELOG.md and merge sometime in the next couple of days, probably before friday.

@coveralls
Copy link

coveralls commented Aug 22, 2022

Coverage Status

Coverage increased (+0.2%) to 90.63% when pulling 1058a67 on Jtmcflea:master into a70a9c8 on RDFLib:master.

Also remove a stray comment.
@aucampia
Copy link
Member

I added a CHANGELOG entry to your branch, feel free to change it if you want, I will check it again before I merge it.

@aucampia aucampia merged commit 04bf774 into RDFLib:master Aug 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Don't register berkelydb as a store if it is not available on the system
3 participants