Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add type hints to rdflib.query and related #2097

Merged

Conversation

aucampia
Copy link
Member

@aucampia aucampia commented Aug 23, 2022

Summary of changes

Add type hints to rdflib.query and result format implementations, also
add/adjust ignores and type hints in other modules to accomodate the
changes.

This does not include any runtime changes.

For a compact diff that excludes non-runtime code, see this.

Checklist

  • Checked that there aren't other open pull requests for
    the same change.
  • Checked that all tests and type checking passes.
  • For changes that have a potential impact on users of this project:
    • Considered updating our changelog (CHANGELOG.md).
  • Considered granting push permissions to the PR branch,
    so maintainers can fix minor issues and keep your PR up to date.

Add type hints to `rdflib.query` and result format implementations, also
add/adjust ignores and type hints in other modules to accomodate the
changes.

This does not include any runtime changes.
@coveralls
Copy link

coveralls commented Aug 23, 2022

Coverage Status

Coverage increased (+0.007%) to 90.643% when pulling 2b755c4 on aucampia:iwana-20220823T2105-typing_query_etc into c487be6 on RDFLib:master.

@aucampia aucampia force-pushed the iwana-20220823T2105-typing_query_etc branch from d0abdc8 to 2b755c4 Compare August 23, 2022 21:22
@aucampia aucampia marked this pull request as ready for review August 23, 2022 21:27
@aucampia aucampia requested a review from a team August 23, 2022 21:44
@aucampia aucampia added the review wanted This indicates that the PR is ready for review label Aug 23, 2022
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

truly heroic

@aucampia aucampia merged commit d11a5ef into RDFLib:master Aug 24, 2022
@aucampia aucampia deleted the iwana-20220823T2105-typing_query_etc branch April 9, 2023 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
review wanted This indicates that the PR is ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants