Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test for issue #2011 #2107

Merged
merged 3 commits into from Sep 4, 2022
Merged

Add test for issue #2011 #2107

merged 3 commits into from Sep 4, 2022

Conversation

mielvds
Copy link
Contributor

@mielvds mielvds commented Sep 2, 2022

This PR adds an xfail test to reproduce issue #2011

@coveralls
Copy link

coveralls commented Sep 2, 2022

Coverage Status

Coverage remained the same at 90.634% when pulling fc1c859 on mielvds:test-po-lists into a563a20 on RDFLib:master.

@aucampia
Copy link
Member

aucampia commented Sep 2, 2022

pre-commit.ci autofix

@aucampia
Copy link
Member

aucampia commented Sep 2, 2022

thanks for the PR @mielvds, I will double check the spec tomorrow and confirm with jena and then merge.

- change format to turtle
- use assert_bindings_collections_equal for checking bindings
- add raises and reason to xfail
@aucampia
Copy link
Member

aucampia commented Sep 4, 2022

The test looks good and seems valid to me also, I made some minor changes to your branch in fc1c859 and will merge it now.

@aucampia aucampia requested a review from a team September 4, 2022 19:35
@aucampia aucampia merged commit 6d21516 into RDFLib:master Sep 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants