Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: type ignore compatibility with latest mypy #2127

Merged
merged 1 commit into from Oct 9, 2022

Conversation

aucampia
Copy link
Member

@aucampia aucampia commented Oct 9, 2022

Summary of changes

New mypy has more specific type errors so the type: ignore[misc] is no longer effective.

Checklist

  • Checked that there aren't other open pull requests for
    the same change.
  • Added tests for any changes that have a runtime impact.
  • Checked that all tests and type checking passes.
  • Considered granting push permissions to the PR branch,
    so maintainers can fix minor issues and keep your PR up to date.

New mypy has more specific type errors so the type: ignore[misc] is no
longer effective.
@aucampia aucampia marked this pull request as ready for review October 9, 2022 12:22
@aucampia aucampia requested a review from a team October 9, 2022 12:24
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@aucampia aucampia merged commit ba43dd7 into RDFLib:main Oct 9, 2022
@aucampia aucampia deleted the iwana-20221009T1414-fix_branch branch April 9, 2023 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant