Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove redundant class #2143

Merged
merged 1 commit into from Nov 19, 2022
Merged

Remove redundant class #2143

merged 1 commit into from Nov 19, 2022

Conversation

veyndan
Copy link
Contributor

@veyndan veyndan commented Oct 24, 2022

Despite the description of the class, we never type check for plist, nor is there a clear reason why we need to. I'm removing it for clarity.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.0009%) to 90.632% when pulling 23648cb on veyndan:rm-plist into 246031b on RDFLib:main.

aucampia
aucampia approved these changes Nov 14, 2022
View reviewed changes
Copy link
Member

@aucampia aucampia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay in review.

I'm okay with this, no good reason for this class to exist.

@aucampia aucampia requested a review from a team November 14, 2022 21:41
@aucampia aucampia merged commit c28270a into RDFLib:main Nov 19, 2022
@veyndan veyndan deleted the rm-plist branch November 19, 2022 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aucampia aucampia aucampia approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@veyndan @coveralls @aucampia