Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

do not write prefix for empty graph id, fix #2154 #2160

Merged
merged 3 commits into from Dec 30, 2022
Merged

Conversation

eroux
Copy link
Contributor

@eroux eroux commented Nov 18, 2022

Summary of changes

Since the names of empty graphs do not appear in the serialization, do not consider them for namespace issues.

fixes #2154

Checklist

  • Checked that there aren't other open pull requests for
    the same change.
  • Added tests for any changes that have a runtime impact.
  • Checked that all tests and type checking passes.
  • For changes that have a potential impact on users of this project:
    • Updated relevant documentation to avoid inaccuracies.
    • Considered adding additional documentation.
    • Considered adding an example in ./examples for new features.
    • Considered updating our changelog (CHANGELOG.md).
  • Considered granting push permissions to the PR branch,
    so maintainers can fix minor issues and keep your PR up to date.

@eroux
Copy link
Contributor Author

eroux commented Nov 19, 2022

Thanks for the merge!

@aucampia
Copy link
Member

Sorry for the delay in review, I will try check by the weekend.

@coveralls
Copy link

Coverage Status

Coverage: 90.63% (-0.004%) from 90.634% when pulling aca39df on eroux:main into 8213b74 on RDFLib:main.

Copy link
Member

@aucampia aucampia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks good to me. For posterity sake, the reason this addresses the problem is that it avoids TurtleSerializer.getQName which would add the namespace of a each graph in a dataset to the collection of namespaces to serialize.

@aucampia aucampia requested a review from a team December 30, 2022 16:11
@aucampia aucampia merged commit 9535070 into RDFLib:main Dec 30, 2022
@eroux
Copy link
Contributor Author

eroux commented Dec 30, 2022

thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

can't get rid of default prefix definition in trig serialization
3 participants