Fix missing query string params in sparqlconnector when using POST method #2180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge `params` into `args["params"]` so that `default-graph-uri` gets sent.
aucampia
approved these changes
Dec 30, 2022
There was a problem hiding this comment.
Thank you for the PR @davidandreoletti. I updated your code slightly to cover the edge case where default-graph-uri is set, and I also changed your test to a parameterized test which checks for this case.
I also made some other slight and mostly cosmetic changes to the test.
|
I will merge tomorrow if there is no further feedback. |
aucampia
added
ready to merge
Sounds good. Thanks. |
davidandreoletti
deleted the
fix-missing-query-string-params-in-sparqlconnector
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
The SPARQLConnector instance created by a SPARQLStore instance providing endpoint url + query string params using POST method did not append the query string to endpoint url.
This PR fixes this.
Backward compatible: yes.
the same change.