Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: gh actions on PR #2731

Merged
merged 9 commits into from
Mar 13, 2024
Merged

fix: gh actions on PR #2731

merged 9 commits into from
Mar 13, 2024

Conversation

edmondchuc
Copy link
Contributor

@edmondchuc edmondchuc commented Mar 12, 2024

Summary of changes

All actions are now passing.

Most of the file changes are due to black formatting.

The readthedocs build is now working again. It stopped working after the readthedocs poetry version was updated to 1.8.x.

A small change was made to the longturtle serializer to fix ruff linting errors with trailing whitespace. Mypy also reported that the removed code was unreachable. This change doesn't appear to affect the longturtle serializer tests.

Checklist

  • Checked that there aren't other open pull requests for
    the same change.
  • Checked that all tests and type checking passes.
  • If the change adds new features or changes the RDFLib public API:
    • Created an issue to discuss the change and get in-principle agreement.
    • Considered adding an example in ./examples.
  • If the change has a potential impact on users of this project:
    • Added or updated tests that fail without the change.
    • Updated relevant documentation to avoid inaccuracies.
    • Considered adding additional documentation.
  • Considered granting push permissions to the PR branch,
    so maintainers can fix minor issues and keep your PR up to date.

@coveralls
Copy link

coveralls commented Mar 12, 2024

Coverage Status

coverage: 90.959%. first build
when pulling d4bf877 on fix/tests
into 7f0c375 on main.

@edmondchuc
Copy link
Contributor Author

pre-commit.ci autofix

@edmondchuc edmondchuc changed the title fix: lock/update poetry.lock file to pyproject.toml fix: local gh actions validate tests Mar 12, 2024
@edmondchuc
Copy link
Contributor Author

pre-commit.ci autofix

@edmondchuc edmondchuc changed the title fix: local gh actions validate tests fix: gh actions on PR Mar 12, 2024
@nicholascar nicholascar merged commit 9834665 into main Mar 13, 2024
20 checks passed
@nicholascar nicholascar deleted the fix/tests branch March 13, 2024 01:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants