Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: typo in Container method name: type_of_conatiner --> type_of_container #2733

Merged
merged 2 commits into from
Mar 20, 2024

Conversation

edmondchuc
Copy link
Contributor

@edmondchuc edmondchuc commented Mar 13, 2024

Summary of changes

Fixes #2689.

  • Add new method rdflib.container.Container.type_of_container
  • Add deprecation warning to rdflib.container.Container.type_of_conatiner

Checklist

  • Checked that there aren't other open pull requests for
    the same change.
  • Checked that all tests and type checking passes.
  • If the change adds new features or changes the RDFLib public API:
    • Created an issue to discuss the change and get in-principle agreement.
    • Considered adding an example in ./examples.
  • If the change has a potential impact on users of this project:
    • Added or updated tests that fail without the change.
    • Updated relevant documentation to avoid inaccuracies.
    • Considered adding additional documentation.
  • Considered granting push permissions to the PR branch,
    so maintainers can fix minor issues and keep your PR up to date.

@coveralls
Copy link

coveralls commented Mar 13, 2024

Coverage Status

coverage: 90.975% (+0.02%) from 90.959%
when pulling 9c9faa0 on fix/issue-2689
into 9834665 on main.

@nicholascar nicholascar merged commit 171c68d into main Mar 20, 2024
20 checks passed
@nicholascar nicholascar deleted the fix/issue-2689 branch March 20, 2024 01:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

typo in Container method name: type_of_conatiner --> type_of_container
3 participants