fix: use guess_format when plugin for format not found #2735
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edmondchuc
commented
Mar 18, 2024
Comment on lines
+1478
to
+1489
| try: | ||
| parser = plugin.get(format, Parser)() | ||
| except plugin.PluginException: | ||
| # Handle the case when a URLInputSource returns RDF but with the headers | ||
| # as a format that does not exist in the plugin system. | ||
| # Use guess_format to guess the format based on the input's file suffix. | ||
| format = rdflib.util.guess_format( | ||
| source if not isinstance(source, InputSource) else str(source) | ||
| ) | ||
| if format is None: | ||
| raise | ||
| parser = plugin.get(format, Parser)() |
There was a problem hiding this comment.
We may be able to factor this logic out into a function. That way, we can test it with a mock URL object rather than a real web request over the network.
nicholascar
approved these changes
Mar 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Fixes #2734
rdflib.util.guess_formatwhenPluginExceptionoccursPluginExceptionstill occurs whenguess_formatfailsChecklist
the same change.
./examples.so maintainers can fix minor issues and keep your PR up to date.