Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: readthedocs failure with poetry 1.8 #2744

Merged
merged 6 commits into from
Mar 20, 2024
Merged

fix: readthedocs failure with poetry 1.8 #2744

merged 6 commits into from
Mar 20, 2024

Conversation

edmondchuc
Copy link
Contributor

@edmondchuc edmondchuc commented Mar 18, 2024

Summary of changes

There's some changed behaviour in readthedocs CI environment and poetry v1.8.0 and above. Running a poetry install does not install into the correct python virtual environment that is set up by readthedocs.

This PR fixes the above issue by performing a poetry export into a requirements.txt file and then installing the dependencies and rdflib itself via pip, ensuring everything is installed into readthedocs virtual environment.

This should unblock the Dependabot PR #2743 that updates poetry to the latest version (1.8.2).

Checklist

  • Checked that there aren't other open pull requests for
    the same change.
  • Checked that all tests and type checking passes.
  • If the change adds new features or changes the RDFLib public API:
    • Created an issue to discuss the change and get in-principle agreement.
    • Considered adding an example in ./examples.
  • If the change has a potential impact on users of this project:
    • Added or updated tests that fail without the change.
    • Updated relevant documentation to avoid inaccuracies.
    • Considered adding additional documentation.
  • Considered granting push permissions to the PR branch,
    so maintainers can fix minor issues and keep your PR up to date.

@edmondchuc edmondchuc marked this pull request as draft March 18, 2024 13:47
@coveralls
Copy link

coveralls commented Mar 18, 2024

Coverage Status

coverage: 90.968% (+0.009%) from 90.959%
when pulling b51b42a on fix/poetry
into 9834665 on main.

@edmondchuc edmondchuc marked this pull request as ready for review March 18, 2024 14:44
@nicholascar nicholascar merged commit 7554bd8 into main Mar 20, 2024
20 checks passed
@nicholascar nicholascar deleted the fix/poetry branch March 20, 2024 01:44
@nicholascar nicholascar self-requested a review March 20, 2024 01:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants