Unpin html5lib 0.95 requirement #360
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to an html5lib regression (described in the thread at https://groups.google.com/d/msg/rdflib-dev/ZcAgKzhS3vI/3mxIJz4rwWUJ) , we opened html5lib/html5lib-python#67 on June 17th, 2013 and pinned html5lib to 0.95 in setup.py. The bug was fixed and a new release of html5lib (1.0b3) was cut on July 24, 2013. The current version of html5lib is 0.999; let's unpin that html5lib requirement. Signed-off-by: Dan Scott <dan@coffeecode.net>
|
seems legit to me, in future when we pin/fix a lib due to a bug and trigger an upstream fix we should maybe leave a long standing issue reminding us of the fact why it was pinned... |
joernhees
added a commit
that referenced
this pull request
Feb 27, 2014
Unpin html5lib 0.95 requirement
dbs
added a commit
to dbs/python-rdflib
that referenced
this pull request
Mar 3, 2014
Per RDFLib/rdflib#360 - remove the pinning of html5lib to 0.95, as versions after 1.0b2 resolve the regression. This patch matches the upstream version. Signed-off-by: Dan Scott <dan@coffeecode.net>
This was referenced Jan 16, 2017
This was referenced Mar 16, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to an html5lib regression (described in the thread at
https://groups.google.com/d/msg/rdflib-dev/ZcAgKzhS3vI/3mxIJz4rwWUJ) , we
opened html5lib/html5lib-python#67 on June 17th, 2013
and pinned html5lib to 0.95 in setup.py. The bug was fixed and a new release of
html5lib (1.0b3) was cut on July 24, 2013. The current version of html5lib is
0.999; let's unpin that html5lib requirement.
Signed-off-by: Dan Scott dan@coffeecode.net