Avoid class reference to imported function #578
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We import the urljoin() function directly to support both Py2 and Py3, so the reference to urlparse.urljoin() raises an exception. Don't do that! Fixes 574. Signed-off-by: Dan Scott <dan@coffeecode.net>
joernhees
added
bug
joernhees
added a commit
that referenced
this pull request
Jan 25, 2016
Avoid class reference to imported function
|
thanks, we'll see what remains after the pyMicrodata cleanup though ;) |
|
closed #574 |
|
@iherman did you sync this? |
|
@joernhees if you mean whether my local copy is in sync with the current master (including your change in adding the csvw to the initial context, thanks for this!) then yes, I am in sync. I plan to update the initial context at the end of February, when some more Recommendations will be added to the mix. |
This was referenced Mar 16, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We import the urljoin() function directly to support both Py2 and Py3, so the
reference to urlparse.urljoin() raises an exception. Don't do that!
Fixes 574.
Signed-off-by: Dan Scott dan@coffeecode.net