Result objects should close the sockets where the results come from #638
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The XMLResult never closed the source file where the result was coming from, resulting in "too man opened files" being raised when processing large amounts of SPARQL queries
jdferreira
changed the title
joernhees
added
bug
|
tests fail... are you sure this behavior still exists in 4.2.2-dev (current master)? |
|
Since that method doesn't open the result, it also shouldn't close it. However, the SPARQLStore probably should, here: https://github.com/RDFLib/rdflib/blob/master/rdflib/plugins/stores/sparqlstore.py#L333 We could do:
|
gromgull
added a commit
that referenced
this pull request
Jan 12, 2017
gromgull
added a commit
that referenced
this pull request
Jan 12, 2017
This was referenced Mar 16, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The XMLResult never closed the source file where the result was coming from, resulting in "too man opened files" being raised when processing large amounts of SPARQL queries. I have added a line of code to the appropriate file, but I am not sure whether other result parsers need to have the same type of fix added to them.