Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix #913 : Added _parseBoolean function to enforce correct Lexical-to-value mapping #995

Merged
merged 8 commits into from Apr 6, 2020
Merged

fix #913 : Added _parseBoolean function to enforce correct Lexical-to-value mapping #995

merged 8 commits into from Apr 6, 2020

Conversation

arushi019
Copy link
Contributor

No description provided.

@arushi019 arushi019 changed the title Fixes https://github.com/RDFLib/rdflib/issues/913 : Added _parseBoolean function to enforce correct Lexical-to-value mapping Fixes #913 : Added _parseBoolean function to enforce correct Lexical-to-value mapping Apr 5, 2020
@arushi019 arushi019 changed the title Fixes #913 : Added _parseBoolean function to enforce correct Lexical-to-value mapping fixes (https://github.com/RDFLib/rdflib/issues/913) : Added _parseBoolean function to enforce correct Lexical-to-value mapping Apr 5, 2020
@arushi019 arushi019 changed the title fixes (https://github.com/RDFLib/rdflib/issues/913) : Added _parseBoolean function to enforce correct Lexical-to-value mapping fix #913 : Added _parseBoolean function to enforce correct Lexical-to-value mapping Apr 5, 2020
@arushi019 arushi019 mentioned this pull request Apr 5, 2020
Closed
white-gecko
white-gecko requested changes Apr 5, 2020
View reviewed changes
Copy link
Member

@white-gecko white-gecko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you be able to add a test as well?

rdflib/term.py Outdated Show resolved Hide resolved
white-gecko
white-gecko reviewed Apr 5, 2020
View reviewed changes
rdflib/term.py Outdated Show resolved Hide resolved
@coveralls
Copy link

coveralls commented Apr 6, 2020 •
edited

Coverage Status

Coverage increased (+0.02%) to 75.913% when pulling 2d4dfce on arushi019:master into 4b114b3 on RDFLib:master.

@arushi019
Copy link
Contributor Author

Would you be able to add a test as well?

Where should I add the tests? Is there a specific file?

@white-gecko
Copy link
Member

Where should I add the tests? Is there a specific file?

https://github.com/RDFLib/rdflib/blob/master/test/test_literal.py should be the right place.

@white-gecko white-gecko added this to the rdflib 5.0.0 milestone Apr 6, 2020
white-gecko
white-gecko requested changes Apr 6, 2020
View reviewed changes
test/test_literal.py Outdated
@@ -163,6 +186,7 @@ def unlexify(s):
self.assertEqual(specific_l.toPython(), s)
self.assertEqual(specific_l.datatype, datatype)


Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please remove this white space line. The rest is cool.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed the whitespace line. Please let me know if any other changes are needed.

@white-gecko white-gecko self-requested a review April 6, 2020 17:01
@nicholascar nicholascar merged commit 604d63e into RDFLib:master Apr 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@white-gecko white-gecko white-gecko approved these changes

@ashleysommer ashleysommer Awaiting requested review from ashleysommer

@nicholascar nicholascar Awaiting requested review from nicholascar

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
rdflib 5.0.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@arushi019 @coveralls @white-gecko @nicholascar