Add enum for QueryTypes #143
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dayures it seems this is failing Python 2.7 check. Do you want 2.7 supported to pass it or are you OK with dropping Python 2 support? In main rdflib, we're planning on support 2.7 for the up-coming 4.3.0 release (to be in about 2 weeks) but then dropping it for the 5.0.0 release (in a few month's time). |
|
@nicholascar this PR not only fails in the python2.7 support. More changes in the code needs to be done. Maybe after some discussion and the finally sw development, we can see if we need to dismiss the python 2.7 support. @MaFeg100 What is the expected value added of adding queryTypes as enum ? |
dayures
added a commit
that referenced
this pull request
Mar 22, 2020
t0b3
pushed a commit
to t0b3/sparqlwrapper
that referenced
this pull request
May 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added a enum for the query types and also worked on the indent of the code.