Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve packaging issues #203

Merged
merged 6 commits into from
Mar 11, 2022
Merged

Resolve packaging issues #203

merged 6 commits into from
Mar 11, 2022

Conversation

eggplants
Copy link
Contributor

@eggplants eggplants commented Mar 6, 2022

  • move all package information to setup.cfg
  • add typed marker to declare SPARQLWrapper is a typed package

setup.cfg Outdated Show resolved Hide resolved
setup.cfg Show resolved Hide resolved
Copy link
Member

@aucampia aucampia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR, looks good, just need to use package_data instead of include_package_data

eggplants and others added 2 commits March 7, 2022 05:04
Co-authored-by: Iwan Aucamp <aucampia@gmail.com>
Co-authored-by: Iwan Aucamp <aucampia@gmail.com>
@eggplants
Copy link
Contributor Author

Changes are duplicated with #201. So please close it after this pr is merged.

Thank you for the PR, looks good, just need to use package_data instead of include_package_data

Thank you. Accepted your suggestions.

Copy link
Member

@aucampia aucampia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, looks good, will merge on friday.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants