-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resolve packaging issues #203
Conversation
eggplants
commented
Mar 6, 2022
•
edited
Loading
edited
- move all package information to setup.cfg
- add typed marker to declare SPARQLWrapper is a typed package
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the PR, looks good, just need to use package_data
instead of include_package_data
Co-authored-by: Iwan Aucamp <aucampia@gmail.com>
Co-authored-by: Iwan Aucamp <aucampia@gmail.com>
Changes are duplicated with #201. So please close it after this pr is merged.
Thank you. Accepted your suggestions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR, looks good, will merge on friday.