Fix basic authentication header #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
base64.encodestring always adds a trailing newline '\n' to the encoded string, which causes httplib to raise ValueError. Using base64.b64encode solves the issue.
|
this fix seems to work, the failing tests seem to be unrelated as they fail for master as well (see #57) shall we merge this? any ideas how to include a test for this? |
|
the bug is caused by using a wrong function. making a test for this case is a bit like adding a regression test for a typo. do you really need it? |
|
well, if we had an end to end test that would (set up and) try to connect to a sparql server with a known username and password, we would've been alerted that something in the auth code is broken in the first place... anyhow, i'll not leave this broken till we find a way to properly test this. |
joernhees
added a commit
that referenced
this pull request
Sep 23, 2015
Fix basic authentication header
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
base64.encodestring always adds a trailing newline '\n' to the encoded string, which causes httplib to raise ValueError. Using base64.b64encode solves the issue.