Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make airlocks move #1315

Merged
merged 24 commits into from
Nov 16, 2023
Merged

Conversation

stilnat
Copy link
Contributor

@stilnat stilnat commented Nov 12, 2023

Summary

Airlocks are back ! Airlocks open and close upon a player getting close to one. See the video below.
No sound for now, we need before a proper audio system to be set up. The one from outdated looks good to me, except turn the singleton into a "System"

credits to @DooblyNoobly for the original PR #137

doc : https://ss3d.gitbook.io/dev-guide/guides/working-with-animations
https://ss3d.gitbook.io/design/environment/tilemaps/tile-objects/airlocks

PR checklist

  • The game builds properly without errors.
  • No unrelated changes are present.
  • No "trash" files are committed.
  • Relevant code is documented.
  • Update the related GitBook document, or create a new one if needed.

Pictures/Videos)

2023-11-12.11-01-33.mp4

Testing

Go close to a civilian airlock, see the magic.

Networking checklist

  • Works from host in host mode.
  • Works from server in server mode.
  • Works on server in client mode.
  • Works and is syncronized across different clients.
  • Is persistent.

Changes

  • Compared to outdated, a major change is the removal of animation events, and using State machine behaviours to get events when the animator gets from one state to another. It won't break if we change the animations for the airlock. It should be a standard to use SMBs instead of animation events, it's just more solid and easier to debug too.

  • Made some changes on the airlock prefab, some renaming so the animations work properly. Let me know if it's an issue and if we should do new animations instead.

Known issues

  • I took the animations from outdated and had to rename right door to left door and left door to right door to make the animation works properly. Otherwise it was "inverted" (doors going inside each other when opening). Not sure how to deal with that properly.

  • in Editor, end of door closing up look not that great. It doesn't occur in build. Don't know how to solve that.

TODO

  • Maybe add some instructions on gitbook on dealing with animations events from now on, using Mecanim's events instead of the legacy ones.
  • Document everything
  • Check that only entity layer can activate doors
  • Check if all the right materials colors are changed.
  • Check the behaviour with multiple players going close to it.
  • Move the state behaviour script in furniture system
  • Put back left and right correctly

Related issues/PRs

close #1316

@cosmiccoincidence

This comment was marked as outdated.

@stilnat

This comment was marked as outdated.

@cosmiccoincidence

This comment was marked as outdated.

@stilnat

This comment was marked as outdated.

@stilnat stilnat changed the title [WIP] Make airlocks move Make airlocks move Nov 14, 2023
Copy link
Member

@cosmiccoincidence cosmiccoincidence left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add new functionality to the SecurityAirlock.prefab as well please, since it is now on the new map.

@stilnat
Copy link
Contributor Author

stilnat commented Nov 15, 2023

@cosmiccoincidence security airlocks updated

Copy link
Member

@cosmiccoincidence cosmiccoincidence left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't test this since before the security door fix, but I'll take your word it's good.

@cosmiccoincidence cosmiccoincidence merged commit 19c4f21 into RE-SS3D:develop Nov 16, 2023
2 checks passed
@stilnat stilnat deleted the make-airlocks-move branch November 21, 2023 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Import airlocks opening and closing
2 participants