Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update PosterVertical.prefab #1419

Merged
merged 1 commit into from
Feb 1, 2024
Merged

Update PosterVertical.prefab #1419

merged 1 commit into from
Feb 1, 2024

Conversation

Sjerty
Copy link
Contributor

@Sjerty Sjerty commented Jan 29, 2024

Summary

Fixed vertical poster sticking out of a wall and drop when placed

PR checklist

  • The game builds properly without errors.
  • No unrelated changes are present.
  • No "trash" files are committed.

Testing

Try placing VerticalPoster from builder menu

Video

https://www.youtube.com/watch?v=uOvFyq5iz6Q

Networking checklist

  • Works from host in host mode.
  • Works from server in server mode.
  • Works on server in client mode.
  • Works and is syncronized across different clients.

Don't quite understand how to check this, because when I close game window and reconnect as a client it won't return me in game, just leave me in the lobby?
But if I join as new client everything is okay

  • Is persistent.

Changes

PosterVertical.prefab - removed it's rigidBody and added a networkObject script so it would update on a client side

Related issues/PRs

Closes #1357

Remove rigidbody, add networkObject
Fixes RE-SS3D#1357
@stilnat
Copy link
Contributor

stilnat commented Jan 29, 2024

@Sjerty Thanks for your work, and welcome to SS3D. I'll check your PR very soon. To answer your question, don't worry too much about this one. disconnecting and reconnecting is currently pretty broken. If it works on client and host at first launch it's all that matters for now.

@Sjerty
Copy link
Contributor Author

Sjerty commented Jan 29, 2024

@stilnat Got it. Thanks for a quick reply! I'm still learning unity and all new stuff that comes with SS3D, but I do have some programmer experience, so I hope one day I'll contribute with something more significant C:

@cosmiccoincidence cosmiccoincidence added the Fix A fix for a bug. label Feb 1, 2024
Copy link
Contributor

@stilnat stilnat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good work, also thanks for the video, makes review faster. Approved ! You are Sjerty on discord too right ? Need to know cause we can add you as a contributor now.

@stilnat stilnat merged commit a91b72f into RE-SS3D:develop Feb 1, 2024
2 checks passed
@Sjerty
Copy link
Contributor Author

Sjerty commented Feb 1, 2024

@stilnat Yes, I'm also "Sjerty" in a discord server, the one with "1000 yard stare cat" profile picture :p

@Sjerty Sjerty deleted the fix/1357 branch February 1, 2024 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fix A fix for a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Placing vertical poster fails
3 participants