-
-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Anchor build menu buttons to the top #1421
Conversation
Yes, you can do multiple issues in one PR if they are small issues and similar to each other. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
* add "Vertical Layout Group" to the MainPanel * add "Layout Element" to the: BuildMenu, Panel * remove TileSearchAndBuild's "Vertical Layout Group" paddings
Made some changes, now there's not so much empty space between Scroll View and Save/Load buttons, but I don't really know if my solution is good enough, bc now menu feels kinda... stretchy?? Not horrible, but still. |
About #1401, there was already code for the change of color, but id didn't work properly So "Color" just didn't work properly, the color didn't apply to the "Build" button and magenta used in code as 0xA900FF, actually darker than the one right now in the game. |
@Sjerty whatever works regarding colors, we don't really have a unified way of dealing with them yet. Your menu looks nice, better than before for sure, I'll take a look at the prefab changes this weekend, github sucks for that. |
Changed Colors to float values and shifted them a bit
Added Activating/Disabling the root of the LoadTab
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
all good, better looking menu.
Summary
Anchor the "Tile search and build" controls to the top of the construction menu
PR checklist
Pictures/Videos
https://youtu.be/n5ZbLStwEW4
Testing
Start the game and play with the construction menu
Networking checklist
Changes
Moved TileSearchAndBuild menu next under the MainPanel instead of ScrollView, set it's anchor to the top-stretch just as Save/Load buttons, removed it's "Layout element" component, also changed all paddings to 5, adjusted sizes of AssetPanel (parent of ScrollView).
There was a problem however, just moving TileSearchAndBuild in the hierarchy and anchor it, didn't work properly, position of the element just jumped to the bottom of construction menu, to prevent that I created another object (Image), added all TileSearchAndBuild settings to it and set it in place, and everything started to work properly.
But I don't quite understand why this didn't work with just moving it in hierarchy, maybe some parenting problem?
Related issues/PRs
Closes #1402
Closes #1401