Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove sample name suffixes and peak picking corner case #212

Merged
merged 3 commits into from Jul 1, 2023

Conversation

xtrojak
Copy link

@xtrojak xtrojak commented Jun 28, 2023

This PR solves two issues since both need to update test files and this way it can be done only once.
The test files updated here (required to be merged first).

Fixed peak picking corner case when an EIC has between 2 and 10 features.
Close #204.

Removed _intensity and _rt suffixes from aligned tables.
Close #211.

@xtrojak xtrojak requested a review from hechth June 28, 2023 12:00
@xtrojak xtrojak marked this pull request as draft June 28, 2023 12:03
@xtrojak xtrojak marked this pull request as ready for review June 29, 2023 07:40
Copy link
Member

@hechth hechth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@xtrojak please update the changelog :)

@codecov
Copy link

codecov bot commented Jun 29, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.07 ⚠️

Comparison is base (d6be955) 65.84% compared to head (5ee4f63) 65.78%.

❗ Current head 5ee4f63 differs from pull request most recent head 8b9231a. Consider uploading reports for the commit 8b9231a to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #212      +/-   ##
==========================================
- Coverage   65.84%   65.78%   -0.07%     
==========================================
  Files          23       23              
  Lines        2685     2680       -5     
==========================================
- Hits         1768     1763       -5     
  Misses        917      917              
Impacted Files Coverage Δ
R/prof.to.features.R 87.05% <ø> (-0.15%) ⬇️
R/feature.align.R 96.38% <100.00%> (ø)
R/recover.weaker.R 98.32% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@hechth hechth self-requested a review July 1, 2023 19:04
@hechth hechth merged commit 6fa5873 into RECETOX:master Jul 1, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants