Loop over enums to create constants #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
REDxEYE
reviewed
Oct 17, 2023
Comment on lines
+267
to
+275
| module = sys.modules[__name__] | ||
| for item in DDSD: | ||
| setattr(module, "DDSD_" + item.name, item.value) | ||
| for item in DDSCAPS: | ||
| setattr(module, "DDSCAPS_" + item.name, item.value) | ||
| for item in DDSCAPS2: | ||
| setattr(module, "DDSCAPS2_" + item.name, item.value) | ||
| for item in DDPF: | ||
| setattr(module, "DDPF_" + item.name, item.value) |
There was a problem hiding this comment.
That's a great idea, but it won't work for code auto-completion, but since these are old/obsolete constants(they are replaced by enums) it's all good
REDxEYE
approved these changes
Oct 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggestions for python-pillow#6486
encoder_name, extents, offset, tile_argsafter looking atfor decoder_name, extents, offset, args in self.tile:. I'm suggesting keepingargs, instead of sometimes havingargsand sometimestile_args.