Support RGB bitcount 8 #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
REDxEYE
reviewed
Oct 28, 2023
Comment on lines
-370
to
-376
| rawmode = rawmode[::-1] | ||
| elif pfflags & DDPF.ALPHA: | ||
| if bitcount == 8: | ||
| self._mode = "L" | ||
| else: | ||
| msg = f"Unsupported bitcount {bitcount} for {pfflags}" | ||
| raise OSError(msg) |
There was a problem hiding this comment.
The ALPHA block only supports a bitcount of 8. With the other changes here, we now support bitcount of 8 for RGB and LUMINANCE.
https://learn.microsoft.com/en-us/windows/win32/direct3ddds/dds-pixelformat states that bitcount is
Valid when dwFlags includes DDPF_RGB, DDPF_LUMINANCE, or DDPF_YUV.
So only YUV is left - I don't think we should support YUV without actually transforming the color, so ALPHA can be removed.
REDxEYE
approved these changes
Oct 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As requested, this allows for DDPF.RGB images with bitcount 8. I created a test image by copying mode-l.dds and manually changing the pfflags.
While thinking about how to do that, I noticed that https://learn.microsoft.com/en-us/windows/win32/direct3ddds/dds-pixelformat states that bitcount is
So I've added a commit to remove using the bitcount only based on DDPF.ALPHA. With my first change, we now support bitcount of 8 for RGB and LUMINANCE. I don't think we should pretend that bitcount of 8 doesn't need color transformation for YUV, so there shouldn't be any loss of functionality.
headeris never used afterwards. So I've removed it.I've added a test for two unimplemented bitcount errors. I copied uncompressed_l.dds and mode-rgb.dds and modified the bitcounts.
I've added tests for BC1_UNORM and BC1_TYPELESS, by copying dxt1-rgb-4bbp-noalpha_MipMaps-1.dds and modifying it. However, I have removed BC1_UNORM_SRGB since that may be different.