Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Ciphey Dockerfile #39

Merged
merged 1 commit into from
Aug 26, 2020

Conversation

malvidin
Copy link
Contributor

This change should have no impact to the usability of the container or command, but with a significant decrease in size (down from 1.95GB to 164MB).

  • Use the Official Python 3.8 slim docker image
  • Remove nonroot user from sudo group, and remove unneeded password
  • Add ENTRYPOINT to simplify running the ciphey command
  • Add additional example to comments for file and text inputs

If the version of Ciphey that is currently in remnux/ciphey is desired, ciphey==5.2.0 can be specified in the pip3 command, but 5.2.0 does not decode the example text input.

Ciphey does not yet include a way to save potential decrypted output to file(s), so references to output files were removed. Standard redirects and pipes will return to the host, not the container. It also includes comments, not just the potentially decrypted final result.

This change should have no impact to the usability of the container or command, but with a significant decrease in size (down from 1.95GB to 164MB).
- Use the Official Python 3.8 slim docker image
- Remove nonroot user from sudo group, and remove unneeded password
- Add ENTRYPOINT to simplify running the ciphey command
- Add additional example to comments for file and text inputs

If the version of Ciphey that is currently in remnux/ciphey is desired, `ciphey==5.2.0` can be specified in the pip3 command, but 5.2.0 does not decode the example text input.

Ciphey does not yet include a way to save potential decrypted output to file(s), so references to output files were removed. Standard redirects and pipes will return to the host, not the container. It also includes comments, not just the potentially decrypted final result.
@lennyzeltser lennyzeltser merged commit d22a8ee into REMnux:master Aug 26, 2020
@bee-san
Copy link

bee-san commented Aug 28, 2020

Hey @malvidin ! One of the inventors of Ciphey here.

Thanks so much for doing this, I was literally working on that this week 😅

If you submit a GitHub issue to Ciphey ( https://github.com/ciphey/ciphey) I can add you as a contributor to the README if you'd want? :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants