Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue 4 add random data generator #9

Merged
merged 12 commits into from Feb 18, 2021
Merged

Issue 4 add random data generator #9

merged 12 commits into from Feb 18, 2021

Conversation

darnjo
Copy link
Member

@darnjo darnjo commented Feb 16, 2021 •
edited

This addresses Issue #3 and #4.

TODO: update the README before merge.

@darnjo
Copy link
Member Author

darnjo commented Feb 16, 2021

@dconroy here is the PR for the Issue #4 branch, which I believe you already branched off of for Issue #7. Perhaps we could merge this into that branch?

@darnjo darnjo requested a review from dconroy February 16, 2021 03:28
dconroy
dconroy approved these changes Feb 17, 2021
View reviewed changes
Copy link
Collaborator

@dconroy dconroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is good to go as it addresses Issues #3 and #4. I did move the generation script over to an admin function and did some loose documentation before we add swagger docs.

@darnjo darnjo merged commit 1b1f67f into main Feb 18, 2021
This was linked to issues Feb 18, 2021
Add tests and CI/CD pipeline through GitHub #3
Closed
Add Random Data Generator #4
Closed
@dconroy dconroy deleted the issue-4-add-random-data-generator branch February 18, 2021 02:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dconroy dconroy dconroy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Random Data Generator Add tests and CI/CD pipeline through GitHub
2 participants
@darnjo @dconroy