Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes perlcritic return undef in 14_SD_WS #1006

Merged
merged 3 commits into from
Aug 13, 2021
Merged

Conversation

elektron-bbs
Copy link
Contributor

  • Please check if the PR fulfills these requirements
  • Tests for the changes have been added / modified (needed for for bug fixes / features)
  • commandref has been added / updated (needed for bug fixes / features)
  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
  • Bugfix (please link issue)
  • Feature enhancement
  • Documentation update
  • Unittest enhancement
  • other
  • What is the current behavior?
    (You can also link to an open issue here, if this describes the current behavior)
    Perlcritic return undef

  • What is the new behavior (if this is a feature change)?
    No Perlcritic return undef

  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
    no

  • Other information:

@codecov
Copy link

codecov bot commented Aug 12, 2021

Codecov Report

Merging #1006 (5e582da) into master (1ad9a12) will decrease coverage by 0.01%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1006      +/-   ##
==========================================
- Coverage   49.49%   49.47%   -0.02%     
==========================================
  Files         217      217              
  Lines       15184    15182       -2     
  Branches     2841     2841              
==========================================
- Hits         7515     7512       -3     
- Misses       6053     6054       +1     
  Partials     1616     1616              
Flag Coverage Δ
fhem 49.31% <50.00%> (-0.02%) ⬇️
modules 49.47% <50.00%> (-0.02%) ⬇️
perl 50.75% <ø> (-0.02%) ⬇️
unittests 49.47% <50.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
FHEM/14_SD_WS.pm 55.47% <50.00%> (-0.14%) ⬇️
local/lib/perl5/Test2/Util/HashBase.pm 45.31% <0.00%> (-1.57%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1ad9a12...5e582da. Read the comment docs.

@elektron-bbs elektron-bbs merged commit 020a8d8 into master Aug 13, 2021
@elektron-bbs elektron-bbs deleted the master_critic_SD_WS branch September 8, 2021 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants