Update compile_config.h #156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unused Pin 11 AS Input pullup
Add all pins as input pullup
|
@sidey79 kommt hier noch mehr oder ist dieser PR nur offen wegen dem Conflicting files? |
|
Den PR hatte ich ursprünglich zum Test von Code ql, einen source code Scanner aufgemacht. Da kam aber nichts bei raus. Naja, das Setzen der Input Pins könnten wir ja machen. Das sollte generell nicht schaden. |
Size report for commit: 0d3dba5
|
src/compile_config.h
Outdated
| @@ -44,7 +44,8 @@ | |||
| * **************************************** | |||
| */ | |||
|
|
|||
| #define PROGVERS "3.5.0-dev+20201221" | |||
|
|
|||
| #define PROGVERS "3.5.0-dev+20204162" | |||
There was a problem hiding this comment.
@sidey79
wir können gern den PR übernehmen aber gern würde ich vorher die PROGVERS abändern ;-)
Das Datum 20204162 gibt es nicht. Du meintest bestimmt 20210416
|
Ich hätte aber gerne noch eine Antwort auf meine Frage ganz am Anfang ;-) |
corrected progvers
|
@elektron-bbs |
Size report for commit: e0cd7c0
|
|
Mhmm, ich hatte da noch eine Änderung in src/signalduino.h e8d249b gesehen.
|
|
Das Kommentar sehe ich nirgendwo. :( Das Kommentar bezieht sich auf einen codezeile die ich bereits durch eine schleife 2-12 ersetzt habe. |
elektron-bbs
approved these changes
Apr 21, 2021
There was a problem hiding this comment.
Das Kommentar sehe ich nirgendwo. :(
Eigenartig :-(
Das Kommentar bezieht sich auf einen codezeile die ich bereits durch eine schleife 2-12 ersetzt habe.
Das habe ich übersehen bzw. nach 5 Monaten nicht mehr im Gedächtnis gehabt.
Dann spricht m.E. nichts mehr gegen die Übernahme.
| @@ -97,7 +97,7 @@ void setup() { | |||
| } | |||
|
|
|||
|
|
|||
|
|
|||
| pinAsInputPullUp(11); | |||
| //delay(2000); | |||
There was a problem hiding this comment.
Mhmm, wozu soll das gut sein?
In Zeile 127 wird der Anschluss wieder zum Ausgang:
pinAsOutput(PIN_SEND);
|
Können wir hier auf den Button klicken zur Übernahme um diesen abzuhaken oder war es nur ein Test? |
sidey79
added a commit
that referenced
this pull request
Jul 7, 2022
* Make a 3.4 Branch * SIGNALDuino.ino | SIGNALESP.ino Fixes default parameter definition * Implement a Wifi reconnect event to restart the telnet server (#120) * SIGNALESP.ino Implement a Wifi reconnect event to restart the telnet server Set ArduinoJson Version to the desired one * commands.h fixed output of version after ping response * fix names - fix cc1101 name * FIX: value of success must be saved before calling reset() success must be saved before calling reset() because reset() will set it back to FALSE * [SIGNALESP] FIX: Min. timer time for cronTimer is 1ms if duration is greater than maxPulse it could happen that the timer time for the cronjob timer becomes negative (or a big value if it is unsigned) * NEW: Settings if LED_BUILTIN on WEMOS boards as PIN_LED * baseline for plattformio * Changes to be compatible with plattformio * signalesp.h prevent crash if first char is a linebreak or # * commands.h fix unsupported command output which caused a crash * Arduino IDE compatibility Added sym links to project files to support arduino compatible layout * Linked ArduinoJson per file * platformio.ini corrected exclude for arduino-ide compatible directory * corrected CMakeLists.txt for testproject added testproject to plattformio.ini (does not work) * build.sh updated build config and travis config for arduino-ide dir structure * change travis build config * clear links * modified symlinks to be relative * remove some symlinks to add again * added symlinks again * rename dir * removed file to link later * added symlinks * build.sh deploy.sh executable flag added * added missing timerone header * added missing cpp file * fix compile * travis changed arduino core version to 2.6.3 * travis update arduino cmd * fixed arduino cmd * added missing symlinks * cc1101.cppAdded wait_miso call after select to repair factory reset * signalesp.h fixed crash with ; as command * signalesp.h modified connection handling commands.h added dumpEEPROM when doing factory reset * SimpleFIFO.h enqueue: ICACHE_RAM_ATTR added to support usage via interrupt * Version 3.4.0-dev+20200216 * platformio.ini added nanocc1101 and nanocc1101@debug * send.h fix unexpected serial print until null termination char is found * platformio.ini Compile definition for serval boards added * send.h cleanup some code * signalDecoder/src/signalDecoder.cpp prevents crashes * Update some compile errors * Update platformio.ini * added different bootloaders * revised HW names * revised minicul 8/16MHz * added monitor_port / upload_port variable to define on start * Update cc1101.cpp * fix - no compile in Arduino IDE from nano, promini, esp8266 without cc1101 but with DEBUG flag - no compile in PlatformIO from nano, promini, esp8266 without cc1101 but with DEBUG flag * Update signalduino.h * revised PROGVERS * Update signalduino.h * wrong date from PR * Update platformio.ini * revised ESP32 config to upload and view monitor * Update platformio.ini * revised ESP32 device useful note * duplicate ESP32 device for DEBUG * commands.h add 0x17 chipid for cc1101 * Update commands.h Fixes syntax, corrected chipid #133 * ESP32 support (#134) * revised for ESP32 (#130) platformio.ini * revised * remove comments & sort devices * remove @lastest comment from esp8266 compile_config.h * added PIN´s for ESP32 * revised comments signalesp.h * revised code for ESP32 (timings, WiFi.events) * fix code line event signalduino.h * revised date README.md * added doc * Update .travis.yml - ESP32 compile (#137) * Update .travis.yml * option to compile ESP32 11d8ece * Update .travis.yml * option to compile ESP32 without cc1101 11d8ece * Maple Mini (stm32f103cbt6) support (#136) * Hardware stm32f103cbt6 integrated * code and config adapted to compile with and without cc1101 * Update dev r3.4 with PlattformIO Updates incl STM Support (#138) * signalesp.h prevent crash if first char is a linebreak or # fixed crash with ; as command modified connection handling * commands.h added dumpEEPROM when doing factory reset fix unsupported command output which caused a crash add 0x17 chipid for cc1101 * Arduino IDE compatibility Added sym links to project files to support arduino compatible layout * Linked ArduinoJson per file * platformio.ini corrected exclude for arduino-ide compatible directory * corrected CMakeLists.txt for testproject added testproject to plattformio.ini (does not work) * build.sh updated build config and travis config for arduino-ide dir structure * travis changed arduino core version to 2.6.3 * cc1101.cpp Added wait_miso call after select to repair factory reset * SimpleFIFO.h enqueue: ICACHE_RAM_ATTR added to support usage via interrupt * send.h fix unexpected serial print until null termination char is found cleanup some code * signalDecoder/src/signalDecoder.cpp prevents crashes * Update some compile errors * ESP32 support (#134) * Maple Mini (stm32f103cbt6) support (#136) * Update platformio.ini (#141) * added radinoCC1101 to compile * revised comments * testet again all PIN´s and compatibility (ICT radino is based on Arduino Leonardo & Micro) * fix - strobe commands register (#140) * Update cc1101.cpp * fix strobe commands register * Update / fix deploy travis config (#142) * travis.yml updated yml for successful deployment of release fixed some yaml warnings on travis * extension of xFSK mode (#145) * xFSK extension extra_script.py * creation file for easy file generation (firmware) platformio.ini * extension of hardware and special debug versions any files: bitstore.h, cc1101.cpp, cc1101.h, commands.h, compile_config.h, functions.h, output.cpp, output.h, send.h, signalDecoder.cpp, signalDecoder.h, signalSTM.h, signalduino.h, signalesp.h * extension of xFSK mode (send & receive) * change notation of calls due to excessive memory consumption (smaller alternative is used) * memory comparison completed -> optimizations for the program sequence - processing on weak hardware runs faster, example: radino, nano - more memory space of the processors * revised debug texts * create symblink * Update signalDecoder.cpp * revised comment for a clear statement * Update signalDecoder.h * added comments * added SIGNALduino project query added for linkage * Update output.cpp * added SIGNALduino project query added for linkage * rename variable and revised comments * revised comments to better understanding * optimized code / string class / xFSK send call cc1101.cpp * revised string class in void sendFIFO * optimized void sendFIFO cc1101.h * revised call void send.h * optimized call xFSK to send * Update output.cpp * revised size comments * Update signalDecoder.h * added comments * macro SDC_PRINT, SDC_WRITE, SDC_PRINTLN inserted to test * Update compile_config.h * Update compile_config.h * revised code signalDecoder.cpp * MSG_PRINT | DBG_PRINT write back to SDC_PRINT * optimized some lines output.cpp * revised comments * back to big memory size functions signalDecoder.cpp * back to big memory size sprintf to save ready compile platformio.ini * revised some comments to view result * Update signalDecoder.cpp * back to big memory size sprintf to save ready compile * Update signalDecoder.cpp * back to big memory size sprintf to save ready compile * Update platformio.ini * revised comments size & version * Update signalDecoder.cpp * fix not compile with define DEBUGDECODE (wrong parameter, macro "SDC_WRITE" passed 2 arguments, but takes just 1) * Update signalDecoder.cpp * fix not compile with define DEBUGDECODE (in POI | error: initializing argument 1 of .... ) * Update platformio.ini * sort hardware for better overview * revised sketch size comments * Update compile_config.h * Update output.cpp * for test * delete output.cpp * delete output.cpp (UNITTEST have no link to compile_config.h) * added functions in some files * update code after REVIEW send.h * #145 (comment) * remove omment compile_config.h * #145 (comment) * revised PROGVERS variable cc1101.cpp * corrected indentation signalDecoder.h * #145 (comment) * comment changed * create output.cpp for functions in project cc1101.cpp * transfer function MSG_PRINTtoHEX functions.h * transfer function DBG_PRINTtoHEX * create symblink * fix output ESP32 & ESP 8266 (#148) * fix output ESP32 & ESP 8266 - fix, no calling of commands possible * dev-r3.5_xFSK_tab_comments - revision indentation (#149) * Update signalDecoder.cpp * revised indentations * revised comments * Update signalDecoder.h * revised comments * Update compile_config.h * revised version * sketch optimized for hardware with little flash (#150) * sketch optimized for hardware with little flash * platformio.ini - revised sketch size comments * signalesp.h - increase writeBufferSize * compile_config.h - revised PROGVERS - revised comments * signalDecoder.h - added new function * signalDecoder.cpp - added new functions myitoa (selfmade alternative to non standard itoa function c++) - remove some sprintf and revised to alternate better sketch size function SDC_PRINT - remove old comments - added function SDC_PRINT_intToHex / nibble_to_HEX - limit array * fix writeBufferSize for ESP * fix writeBufferSize for ESP (#151) * CI Jobs auf Gihub actions übertragen (#152) * .github\workflows\unittest.yml Added unittest workflow Made scrips executable and renamed travis ci yaml file Use more recent (latest supported rapidassist) version added all boards and combinations to workflow excluded some combinations Added github actions unittest workflow, which tests and uploads to a created relese * Compile micro8 mhz (#155) * .github\workflows\unittest.yml - added radino board with incicuit board files - Added dependency between unittest and deploy jobs to run in sequence - renamed firmware to be compatible with flash command from module * Update README.md Updated badge in readme * Codequality check via Github Actions (#154) * Create codeql-analysis.yml * Delete build.sh * Delete deploy.s * created .github\actions\arduino-cli\action.yml move common steps to prepatr arduino-cli into a composite step and refenrence on it in the workflows: - workflows/codeql-analysis.yml - workflows/unittest.yml * Upload compiled firmwares always as artifacs (#159) Artifacts are always placed at github actions to get the compiled firmware files * fix-esp8266-firmware-debug (#158) * ./github/unittest.yml - Removed debug options for compiler (esp8266) #157 - Upload compiled firmwares always as artifacs (#159) - generate a comment output with the flash and ram usage - changed submodule checkout to checkout action * unittest.yml run comments only if this is a pullrequest * Update action.yml spell fix * Update compile_config.h (#156) * Update signalduino.h Add all pins as input pullup * Fix wait_Miso defines in cc1101.h (#213) Static variables are only initialized once so the implementation only worked for a total of 255 iterations. After that, functions like cmdStrobe(), readReg() or writeReg() return immediately if the MISO pin is high. The variable miso_count is now out of while's scope and therefore no longer needs to be static. * Fix - GFSK & nano crash (#211) * dev-r3.5_xFSK Bugfix GFSK - Allows other modulations than ASK / OOK and 2-FSK to be received. * fix nano328 send crash - revised PROGVERS - pins excluded to avoid crash - revised comment & changed pins - revised code PullUp loop #211 (comment) * Fixes a endless loop in mcdecoder (#228) * CMakeList.txt - Added policy for new cmake versions * win32arduino - updated to newest version * test.cpp - Added test to find endlesslopp * signalDecoder.cpp - try to avoid var overflow - modify if conditions checking * signalDecoder.cpp - Fix not stopping early enough * signalDecoder.cpp - fix to last exit for shorts * signalDecoder.cpp - revert mpi and mpiplusone checking * install_rapidassists.sh - Update to version 0.10.0 to be compatible with win32arduino * Update codeql-analysis.yml , platformio.ini (#244) * Update codeql-analysis.yml * Update platformio.ini - remove old event - update information - comment out hardware bootloader_v2 due to errors in the core * Update unittest.yml * Update signalDecoder.cpp (#245) * Update signalDecoder.cpp - fix, code cannot compile with debug option DEBUGDECODE * Update codeql-analysis.yml - use actions checkout also for submodules * LED confirms receipt of FSK (#251) Pin reception works at FSK inverted to OOK. * Update platformio.ini - useful hints added Co-authored-by: HomeAutoUser <abfall-container@gmx.de> Co-authored-by: uwekaditz <55511593+uwekaditz@users.noreply.github.com> Co-authored-by: devzero84 <devzero84@users.noreply.github.com> Co-authored-by: Udo <info@elektron-bbs.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brings all inputputs for arduino builds in a defined state to avoid floating input pins