New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New release #276
Comments
Thanks! |
Should I now upload the new R version to CRAN based on the pushed 3.5.0 tag? |
Hi @mlampros |
@fukatani Thanks a lot! |
Besides the init_model parameter and the save_model method (version 1.0.5.2) is there something else that should be added to the R package that I'm not aware of? |
According to the history starting from |
thanks StrikerRUS. I'll proceed with the submission to CRAN and once accepted, I'll upload the new version to the rgf repository (pull request) |
@mlampros Gracias! |
The R-package passed the CRAN tests. I opened pull request 277. Now it remains to add a few test cases for the new features ( ping to @jameslamb ) |
@fukatani Don't you know what is this?! |
I have no idea 😲 |
@mlampros good morning! Yes we tried addressing #269 but found it was really hard to build So basically if your Python setup isn't correct the R tests just silently skip and can trick you into thinking the package is building fine. I'm committed to coming back to it though! |
@fukatani Don't you mind to replace the badge with working one? |
@StrikerRUS No, I don't. |
I suppose it's time to release a new version with the support of warm start.
@fukatani Please release new Python version, and then @mlampros please upload to CRAN new R version.
The text was updated successfully, but these errors were encountered: