Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New release #276

Closed
StrikerRUS opened this issue Jan 13, 2019 · 16 comments
Closed

New release #276

StrikerRUS opened this issue Jan 13, 2019 · 16 comments
Assignees

Comments

@StrikerRUS
Copy link
Member

I suppose it's time to release a new version with the support of warm start.

@fukatani Please release new Python version, and then @mlampros please upload to CRAN new R version.

@fukatani
Copy link
Member

Thanks!
I pushed tag 3.5.0.

@mlampros
Copy link
Collaborator

Should I now upload the new R version to CRAN based on the pushed 3.5.0 tag?

@StrikerRUS
Copy link
Member Author

@fukatani Thank you!

@mlampros I think you should wait till @fukatani upload new release to PyPI. @fukatani Please ping @mlampros when it'll be done.

@fukatani
Copy link
Member

Hi @mlampros
pypi 3.5.0 version is uploaded

@StrikerRUS
Copy link
Member Author

StrikerRUS commented Jan 15, 2019

@fukatani Thanks a lot!
@mlampros Please don't forget to merge recent changelogs into one under 1.0.6 version as we discussed here #273 (comment)

@mlampros
Copy link
Collaborator

Besides the init_model parameter and the save_model method (version 1.0.5.2) is there something else that should be added to the R package that I'm not aware of?

@StrikerRUS
Copy link
Member Author

According to the history starting from Commits on Sep 28, 2018 | R package update to CRAN version 1.0.5 (#250) | a7c0a5b I don't see anything related to R-package that isn't listed in the changelog.

@mlampros
Copy link
Collaborator

thanks StrikerRUS. I'll proceed with the submission to CRAN and once accepted, I'll upload the new version to the rgf repository (pull request)

@StrikerRUS
Copy link
Member Author

@mlampros Gracias!

@mlampros
Copy link
Collaborator

mlampros commented Jan 15, 2019

The R-package passed the CRAN tests. I opened pull request 277. Now it remains to add a few test cases for the new features ( ping to @jameslamb )

@StrikerRUS
Copy link
Member Author

@fukatani Don't you know what is this?!

image

@StrikerRUS
Copy link
Member Author

StrikerRUS commented Jan 16, 2019

BTW, shields.io version is OK: PyPI Version

[![PyPI Version](https://img.shields.io/pypi/v/rgf_python.svg)]

@fukatani
Copy link
Member

I have no idea 😲

@jameslamb
Copy link
Contributor

@mlampros good morning! Yes we tried addressing #269 but found it was really hard to build RGF R package and run the tests. I think on previous PRs I'd tricked myself into thinking I had built and run it successfully, when in reality I never got past the skip_test_if_no_module checks.

So basically if your Python setup isn't correct the R tests just silently skip and can trick you into thinking the package is building fine.

I'm committed to coming back to it though!

@StrikerRUS
Copy link
Member Author

@fukatani Don't you mind to replace the badge with working one?

@fukatani
Copy link
Member

@StrikerRUS No, I don't.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

4 participants